Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • 4 4ME
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 118
    • Issues 118
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • 4ME
  • 4ME
  • Merge requests
  • !424

Remove onError event from KeyboardDateTimePicker component, for date start and...

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Steeve DESCARPENTRIES / ext/octo requested to merge 716-CRASH_EDIT_PERIOD_MAIL into master Sep 05, 2022
  • Overview 2
  • Commits 3
  • Pipelines 2
  • Changes 2

Contexte

Bug Frontend in messaging module, when edit an existing mail. The modification of start or end date fall into an endless loop.

Présentation MR

A collision existed between the yup form validation and the integrated KeyboardDateTimePicker format validation process. To be coherent with the existing code, I just removed the format validation of KeyboardDateTimePicker. The date validation is rightfully made by the existing yup form validation method. A tiny difference will be introduce, the abbility to write a false date or time, like more than 60 seconds, or minutes. Able to write it, but not able to validate the form.

Closes #716 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 716-CRASH_EDIT_PERIOD_MAIL

Vous utilisez actuellement l'un des services de la communauté ASAP. Les interventions sont diffusées uniquement sur Mattermost / ASAP / Outils. Par ailleurs, la documentation Gitlab est accessible sur le Wiki DSNA.